Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type for Schema list API #466

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix return type for Schema list API #466

merged 1 commit into from
Oct 21, 2024
+112 −114

Conversation

ThomasCAI-mlv
Copy link
Collaborator

@ThomasCAI-mlv ThomasCAI-mlv commented Oct 11, 2024 •
edited
Loading

The list schema endpoint with wildcard will be the main endpoint to get one or multiple schemas.
This PR handles whether the returned information from this endpoint is filled with compatibility, schema id, type, version or not:

  • When there is one schema returned, the endpoint returns all information.
  • When there are 2 schemas or more, the endpoint only returns the subject name.

@ThomasCAI-mlv ThomasCAI-mlv added the bug Something isn't working label Oct 11, 2024
@ThomasCAI-mlv ThomasCAI-mlv self-assigned this Oct 11, 2024
@ThomasCAI-mlv ThomasCAI-mlv marked this pull request as ready for review October 11, 2024 14:49
@ThomasCAI-mlv ThomasCAI-mlv force-pushed the fix/schema-controller-return-type branch from 753872c to 6b836e5 Compare October 18, 2024 14:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

loicgreffier
loicgreffier approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@loicgreffier loicgreffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicgreffier loicgreffier merged commit d28bd5a into master Oct 21, 2024
4 checks passed
@loicgreffier loicgreffier deleted the fix/schema-controller-return-type branch October 21, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicgreffier loicgreffier loicgreffier approved these changes

Assignees

@ThomasCAI-mlv ThomasCAI-mlv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasCAI-mlv @loicgreffier